Skip to content

[RCS1260] False Positive #1439

Description

@viceroypenguin

Product and Version Used:
Roslynator.Analyzers

Steps to Reproduce:
set .editorconfig values:

roslynator_trailing_comma_style = omit_when_single_line
dotnet_diagnostic.RCS1260.severity = warning

Actual Behavior:
Warning RCS1260 on the , at the end of Property1

var value = new Object
{
    Property1 = "Value"{|RCS1260:,|}
}

Expected Behavior:
No warning

var value = new Object
{
    Property1 = "Value",
}

Possible correction:

I believe the following code relies solely on the initializer.Expressions syntax node, when it should be based on the initializer code.

&& expressions.IsSingleLine(cancellationToken: context.CancellationToken))

Other IsSingleLine() checks in this file need similar review.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions