Skip to content

Reduce randomness of invoke benchmarks #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveharter merged 4 commits into from
Oct 18, 2022
Merged

Reduce randomness of invoke benchmarks #2602

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ee3b79
Reduce randomness of invoke benchmarks
steveharter Sep 7, 2022
186efa9
add OPI
Sep 25, 2022
3e7cc74
Address feedback
steveharter Oct 6, 2022
c3d5218
Merge branch 'ReduceRandomnessOnInvoke' of https://github.com/steveha…
steveharter Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 94 additions & 29 deletions src/benchmarks/micro/runtime/System.Reflection/Invoke.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ namespace System.Reflection
[BenchmarkCategory(Categories.Runtime, Categories.Reflection)]
public class Invoke
{
private const int Iterations = 1_000; // Reduce the randomness of these short-lived calls.

private static MyClass s_MyClass = new MyClass();
private static object[] s_args = new object[] { 42, "Hello", default(MyBlittableStruct), s_MyClass };
private static int s_dummy;
Expand All @@ -24,6 +26,9 @@ public class Invoke
private static FieldInfo s_field_int;
private static FieldInfo s_field_class;

public static int s_int;
public static object s_class;

[GlobalSetup]
public void Setup()
{
Expand Down Expand Up @@ -73,90 +78,150 @@ public static void Method_nullableInt(int? i)
s_dummy++;
}

[Benchmark]
[Benchmark(OperationsPerInvoke = Iterations)]
public void Method0_NoParms()
{
s_method.Invoke(s_MyClass, null);
for (int i = 0; i < Iterations; i++)
{
s_method.Invoke(s_MyClass, null);
}
}

[Benchmark]
[Benchmark(OperationsPerInvoke = Iterations)]
// Include the array allocation and population for a typical scenario.
Comment thread
steveharter marked this conversation as resolved.
public void StaticMethod4_arrayNotCached_int_string_struct_class()
{
object[] args = new object[] { 42, "Hello", default(MyBlittableStruct), s_MyClass };
s_method_int_string_struct_class.Invoke(null, args);
for (int i = 0; i < Iterations; i++)
{
object[] args = new object[] { 42, "Hello", default(MyBlittableStruct), s_MyClass };
s_method_int_string_struct_class.Invoke(null, args);
}
}

[Benchmark]
[Benchmark(OperationsPerInvoke = Iterations)]
public void StaticMethod4_int_string_struct_class()
{
s_method_int_string_struct_class.Invoke(null, s_args);
for (int i = 0; i < Iterations; i++)
{
s_method_int_string_struct_class.Invoke(null, s_args);
}
}

[Benchmark]
[Benchmark(OperationsPerInvoke = Iterations)]
public void StaticMethod4_ByRefParams_int_string_struct_class()
{
s_method_byref_int_string_struct_class.Invoke(null, s_args);
for (int i = 0; i < Iterations; i++)
{
s_method_byref_int_string_struct_class.Invoke(null, s_args);
}
}

[Benchmark]
[Benchmark(OperationsPerInvoke = Iterations)]
public void Ctor0_NoParams()
{
s_ctor_NoParams.Invoke(null);
for (int i = 0; i < Iterations; i++)
{
s_ctor_NoParams.Invoke(null);
}
}

[Benchmark]
[Benchmark(OperationsPerInvoke = Iterations)]
public void Ctor0_ActivatorCreateInstance_NoParams()
{
Activator.CreateInstance(typeof(MyClass));
for (int i = 0; i < Iterations; i++)
{
Activator.CreateInstance(typeof(MyClass));
}
}

[Benchmark]
[Benchmark(OperationsPerInvoke = Iterations)]
public void Ctor4_int_string_struct_class()
{
s_ctor_int_string_struct_class.Invoke(s_args);
for (int i = 0; i < Iterations; i++)
{
s_ctor_int_string_struct_class.Invoke(s_args);
}
}

[Benchmark]
[Benchmark(OperationsPerInvoke = Iterations)]
public void Ctor4_ActivatorCreateInstance()
{
Activator.CreateInstance(typeof(MyClass), s_args);
for (int i = 0; i < Iterations; i++)
{
Activator.CreateInstance(typeof(MyClass), s_args);
}
}

[Benchmark]
[Benchmark(OperationsPerInvoke = Iterations)]
public void Property_Get_int()
{
s_property_int.GetValue(s_MyClass);
for (int i = 0; i < Iterations; i++)
{
s_int = (int)s_property_int.GetValue(s_MyClass);
}
}

[Benchmark]
[Benchmark(OperationsPerInvoke = Iterations)]
public void Property_Get_class()
{
s_property_class.GetValue(s_MyClass);
for (int i = 0; i < Iterations; i++)
{
s_class = s_property_class.GetValue(s_MyClass);
}
}

[Benchmark]
[Benchmark(OperationsPerInvoke = Iterations)]
public void Property_Set_int()
{
s_property_int.SetValue(s_MyClass, 42);
for (int i = 0; i < 1000; i++)
{
s_property_int.SetValue(s_MyClass, 42);
}
}

[Benchmark]
[Benchmark(OperationsPerInvoke = Iterations)]
public void Property_Set_class()
{
s_property_class.SetValue(s_MyClass, null);
for (int i = 0; i < Iterations; i++)
{
s_property_class.SetValue(s_MyClass, null);
}
}

[Benchmark]
[Benchmark(OperationsPerInvoke = Iterations)]
public void Field_Get_int()
{
s_field_int.GetValue(s_MyClass);
for (int i = 0; i < Iterations; i++)
{
s_int = (int)s_field_int.GetValue(s_MyClass);
}
}

[Benchmark(OperationsPerInvoke = Iterations)]
public void Field_Get_class()
{
for (int i = 0; i < Iterations; i++)
{
s_class = s_field_class.GetValue(s_MyClass);
}
}

[Benchmark]
[Benchmark(OperationsPerInvoke = Iterations)]
public void Field_Set_int()
{
s_field_int.SetValue(s_MyClass, 42);
for (int i = 0; i < Iterations; i++)
{
s_field_int.SetValue(s_MyClass, 42);
}
}

[Benchmark(OperationsPerInvoke = Iterations)]
public void Field_Set_class()
{
for (int i = 0; i < Iterations; i++)
{
s_field_class.SetValue(s_MyClass, 42);
}
}

public struct MyBlittableStruct
Expand Down