Final branding for 18.0#12593
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MSBuild version configuration to mark version 18.0.0 as a final release version. The change sets the DotNetFinalVersionKind property to "release", indicating this is no longer a preview or pre-release version.
Key Changes
- Sets the final version kind to "release" for MSBuild 18.0.0
JanProvaznik
approved these changes
Oct 2, 2025
Member
|
@AR-May do we have darc and insertions set up correctly? so when we merge we can get a valid insertion. |
Member
|
oh I checked and we don't https://github.com/dotnet/msbuild/blob/vs18.0/azure-pipelines/vs-insertion.yml |
Member
Author
|
Thank you, @JanProvaznik, I am looking at that now! Darc is set but the insertions not, so I will add them to this PR. |
JanProvaznik
reviewed
Oct 2, 2025
MichalPavlik
approved these changes
Oct 2, 2025
rainersigwald
approved these changes
Oct 2, 2025
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
This was referenced Oct 9, 2025
This was referenced Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.