Use Builder in ImmutableDictionary.SetItems extension#12402
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This change optimizes memory allocation in the SetItems extension method for ImmutableDictionary<string, string> by using ImmutableDictionary.Builder instead of a generator-based approach. The modification eliminates the intermediate enumerable allocation while maintaining the same validation logic and null-to-empty-string conversion behavior.
Key Changes
- Replaced
ValidateItemsgenerator method with directBuilderoperations - Eliminated intermediate enumerable allocation, saving ~34MB according to profiling data
- Maintained identical functionality for key validation and null value handling
ccastanedaucf
changed the title
ghost
assigned
AR-May
approved these changes
Sep 22, 2025
AR-May
left a comment
AR-May
left a comment
Member
There was a problem hiding this comment.
Looks good to me. I will make exp insertion and look at numbers.
Member
|
Ok, exp insertion came up showing improvements. merging the PR. |
This was referenced Feb 23, 2026
Merged
Merged
This was referenced Mar 2, 2026
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Small change to avoid allocating a generated enumerable. Using a
Builderhere is otherwise identical in perf toSetItems, as both hit the same paths to allocate a new instance + modified subtree nodes. ~34MB diff below.Before
After
