Skip to content

Do not include -dead_strip when native linking a NativeAOT object file #18553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dalexsoto merged 1 commit into from
Jul 13, 2023
Merged

Do not include -dead_strip when native linking a NativeAOT object file #18553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tools/dotnet-linker/Steps/ComputeNativeBuildFlagsStep.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System.Collections.Generic;

using Xamarin.Utils;
using Xamarin.Bundler;

#nullable enable

Expand Down Expand Up @@ -51,7 +52,8 @@ protected override void TryEndProcess ()
Configuration.Application.DeadStrip = false;

var mainLinkerFlags = new List<MSBuildItem> ();
if (Configuration.Application.DeadStrip) {
// Do not pass -dead_strip to the native linker with object files generated by NativeAOT compiler as it can cause the linker to seg fault
if (Configuration.Application.DeadStrip && Configuration.Application.XamarinRuntime != XamarinRuntime.NativeAOT) {
mainLinkerFlags.Add (new MSBuildItem ("-dead_strip"));
}
Configuration.WriteOutputForMSBuild ("_AssemblyLinkerFlags", mainLinkerFlags);
Expand Down