This repository was archived by the owner on Apr 27, 2026. It is now read-only.
Fix: failure to create new blank notebook and some completion fixes#3719
Merged
Conversation
jonsequitur
force-pushed
the
bug-fixes-oct-15-2024
branch
from
October 17, 2024 22:40
d256a60 to
3ddc440
Compare
jonsequitur
enabled auto-merge (rebase)
October 17, 2024 22:41
shyamnamboodiripad
approved these changes
Oct 18, 2024
| } | ||
|
|
||
| [Fact] | ||
| public void MathString_type_is_formatted() |
Contributor
There was a problem hiding this comment.
MathString is now obsolete - but should this test be preserved until we remove the MathString type?
Contributor
Author
There was a problem hiding this comment.
It's not worth the trouble because the implementation is trivial and essentially identical to LaTeXString and neither has been changed in years.
colombod
approved these changes
Oct 18, 2024
jonsequitur
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes: