This repository was archived by the owner on Apr 27, 2026. It is now read-only.
Fix extraction of 'kernelInfo' from the document -- fixes #3527#3701
Merged
Conversation
jonsequitur
approved these changes
Oct 8, 2024
Contributor
|
Thanks, @pkese! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for the #3527 -- it fixes the problem for me.
I wrote the code in a bit defensive manner, because I was not sure if the old code might still be correct in some cases (e.g. in case some .ipynb files are formatted in the way the code was initially written).
So I tried both options: if the old way doesn't work, then try the new structure format.
If all loaded documents are expected to be written in new format (
metadata.polyglot_notebook.kernelInfoinstead ofmetadata.kernelInfo),then the left side of that 'or' (
||) statement can be omitted.