Skip to content
This repository was archived by the owner on Apr 27, 2026. It is now read-only.

Upgrade F# language version for 8.0#3392

Merged
jonsequitur merged 3 commits into
dotnet:mainfrom
kojo12228:feature/fsharp-8
Dec 22, 2023
Merged

Upgrade F# language version for 8.0#3392
jonsequitur merged 3 commits into
dotnet:mainfrom
kojo12228:feature/fsharp-8

Conversation

@kojo12228

Copy link
Copy Markdown
Contributor

Also update another reference to C# language to 12 (the other one being amended in #3338).

Because the language version in compiler args is preview anyway, this doesn't matter too much (although it did surprise me that it was set to preview).

@jonsequitur

Copy link
Copy Markdown
Contributor

Thanks, @kojo12228! This is a good catch.

The change you made doesn't affect the actual language version but it affects the language version that these two kernels advertise. There's probably a way (such as a test) to better keep these in sync in the future.

It incidentally caused one of the contract tests to fail.

This value should probably not be in the constructor for CSharpLanguageInfo and FSharpLanguageInfo since it's very much a moving target. But for now I'll hand-edit the approval file which should unblock this PR, and I'll open an issue for that afterwards.

@jonsequitur
jonsequitur enabled auto-merge (squash) December 22, 2023 18:42
@jonsequitur
jonsequitur merged commit bc12bb7 into dotnet:main Dec 22, 2023
@colombod colombod added the Area-F# Specific to F# label Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Area-F# Specific to F#

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants