This repository was archived by the owner on Apr 27, 2026. It is now read-only.
Disallow token change via SetParent after a command has been deserialized#3389
Merged
Conversation
jonsequitur
force-pushed
the
disallow-token-change
branch
from
January 2, 2024 22:25
1c4ca0c to
99077da
Compare
jonsequitur
force-pushed
the
disallow-token-change
branch
from
January 2, 2024 22:38
99077da to
056cf28
Compare
jonsequitur
marked this pull request as ready for review
January 2, 2024 23:35
jonsequitur
enabled auto-merge
January 2, 2024 23:36
Member
|
Should we have changes in typescript too? |
Member
|
#3396 will align js to this |
colombod
approved these changes
Jan 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a command, after deserialization, can have its parent set again, overwriting the original token and breaking scheduler correlation.