This repository was archived by the owner on Apr 27, 2026. It is now read-only.
Check for embedded expressions in Url Node#3345
Merged
Merged
Conversation
jonsequitur
approved these changes
Nov 27, 2023
shyamnamboodiripad
approved these changes
Nov 27, 2023
jonsequitur
enabled auto-merge (squash)
November 27, 2023 18:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the check for embedded expressions in url nodes as well as a test to make sure that variables in the request are still sent to the kernel