This repository was archived by the owner on Apr 27, 2026. It is now read-only.
amend cursor position decrement logic & create language service command kernel test#3281
Merged
Conversation
cartercanedy
force-pushed
the
create-tests
branch
from
October 19, 2023 20:51
107b430 to
dd3528d
Compare
Member
|
Thank you for this contribution |
colombod
approved these changes
Oct 19, 2023
Contributor
|
Thanks for the contribution @cartercanedy! Could you please clarify why the test was excluded from netfx? I see that some other tests in the file were already excluded - but I don't remember why. |
Contributor
Author
|
It looks like the test case is available for both netcore and netfx through Microsoft.DotNet.Interactive.Tests Microsoft.DotNet.Interactive.VisualStudio.Tests. The test uses a CSharpKernel nested in a CompositeKernel, which is unavailable in the latter. |
Contributor
|
Ah indeed - that makes sense. I was wondering if there was some other reason why the test fails on netfx. Thanks for clarifying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: