This repository was archived by the owner on Apr 27, 2026. It is now read-only.
fix parsing of multiple comment lines#3175
Merged
Merged
Conversation
jonsequitur
force-pushed
the
combinatorial-testing-5
branch
from
September 14, 2023 01:23
f9ffa19 to
316e566
Compare
| private IEnumerable<HttpCommentNode> ParseComments() | ||
| { | ||
| if (IsComment()) | ||
| while (IsComment()) |
Contributor
There was a problem hiding this comment.
We may have another bug if there is a blank line (or a line with only whitespaces) in between two comments.
| foreach (var comment in ParseComments()) | ||
| { | ||
| requestNode.Add(commentAfterHeaders); | ||
| requestNode.Add(comment); |
Contributor
There was a problem hiding this comment.
Consider: It may be useful to introduce an HttpSyntaxNode.AddRange method for comments.
shyamnamboodiripad
approved these changes
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds combinatorial testing to produce test cases with multiple consecutive line comments in all of the valid positions, and fixes the previous issue with parsing them.