fix #2095: remove SubmitCode.SubmissionType#3174
Conversation
| } | ||
| break; | ||
| case IncompleteCodeSubmissionReceived _: | ||
| Reply(false, context.JupyterRequestMessageEnvelope, context.JupyterMessageSender); |
There was a problem hiding this comment.
Were the removed code paths pretty much unused?
There was a problem hiding this comment.
They're unused after this code change.
There was a problem hiding this comment.
I am not very familiar with the code, but the current class is called IsCompleteRequestHandler and I was a bit confused since it seemed like it was meant to check whether the complete submission has been received while now it checks whether or not the submission contains errors. Do we need to rename this for clarity?
There was a problem hiding this comment.
Checking for errors is an implementation detail. This handler's purpose is the same as before, which is to inform the Jupyter console as to whether a code submission is "complete". This isn't a common use case for us in any event.
6184d1b to
c4706f4
Compare
c4706f4 to
df610ec
Compare
3 participants
Fixes #2095.