This repository was archived by the owner on Apr 27, 2026. It is now read-only.
Replace Buildalyzer from CSharpProject#3112
Merged
ocallesp merged 5 commits intoAug 26, 2023
Merged
Conversation
Closed
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
jonsequitur
reviewed
Aug 1, 2023
Contributor
Author
|
@colombod Fixed the issue with Document Ids in the last commit. These are the 3 remaining unit-tests 
|
jonsequitur
reviewed
Aug 2, 2023
jonsequitur
reviewed
Aug 2, 2023
jonsequitur
reviewed
Aug 2, 2023
jonsequitur
reviewed
Aug 2, 2023
jonsequitur
reviewed
Aug 2, 2023
|
|
||
| namespace Microsoft.DotNet.Interactive.CSharpProject.RoslynWorkspaceUtilities; | ||
|
|
||
| public class BuildDataResults |
Contributor
There was a problem hiding this comment.
Does this need to be public?
For every type introduced, we should make it internal if it's simple to do so. For the ones where it's less clear (for example you're using them in unit tests), let's have a discussion when we meet.
Contributor
Author
There was a problem hiding this comment.
In order to accomplish this, I will need to make other classes 'internal'.
I can implement these changes once I gain a clearer understanding of which APIs the service will utilize
Contributor
There was a problem hiding this comment.
It's better to make them internal until a clear need for them to be public emerges.
The main public methods that the Try .NET web service will need to call will be the kernel commands and events, and this infrastructure should be an implementation detail.
jonsequitur
reviewed
Aug 2, 2023
jonsequitur
reviewed
Aug 2, 2023
jonsequitur
reviewed
Aug 2, 2023
Contributor
Author
|
Git squash |
Contributor
Author
|
I removed the last commit and did a git rebase onto upstream main to get the package upgrade in Markdig.Signed Can someone approve ? |
ocallesp
enabled auto-merge
August 21, 2023 20:34
jonsequitur
reviewed
Aug 21, 2023
jonsequitur
reviewed
Aug 21, 2023
jonsequitur
reviewed
Aug 21, 2023
jonsequitur
reviewed
Aug 21, 2023
jonsequitur
reviewed
Aug 21, 2023
jonsequitur
reviewed
Aug 21, 2023
jonsequitur
reviewed
Aug 21, 2023
jonsequitur
reviewed
Aug 21, 2023
jonsequitur
reviewed
Aug 21, 2023
jonsequitur
reviewed
Aug 22, 2023
jonsequitur
reviewed
Aug 22, 2023
jonsequitur
reviewed
Aug 25, 2023
| catch (Exception) | ||
| catch (ArgumentNullException) | ||
| { | ||
| return null; |
Contributor
There was a problem hiding this comment.
Why are we hiding an exception here at all? This is presumably happening due to a bug in our code.
jonsequitur
reviewed
Aug 25, 2023
| { | ||
| // Error | ||
| return null; | ||
| throw new ArgumentNullException(nameof(projectInfo)); |
Contributor
There was a problem hiding this comment.
This isn't the correct exception type, since it's not an argument.
What causes projectInfo to be null? Is it due to a bug somewhere else?
Contributor
Author
There was a problem hiding this comment.
I'll push a cleanup pr to fix this
jonsequitur
approved these changes
Aug 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request seeks to eliminate all dependencies on Buildalyzer, due to its frequent breakdown during runtime. The instability can be attributed to frequent changes in the binlog format, necessitating either a regular update of Buildalyzer to the latest version supporting the new format, or the submission of respective updates to the Buildalyzer project repository.
This update involves numerous changes, the crux of which is a revision to the build process. During the build, a temporary file named Directory.Build.Targets is generated. This file initiates the creation of a target called DirectoryBuildTargetsContent which, in turn, generates a cache file containing all the necessary data to create a Roslyn Workspace object.
Subsequent to this update, instead of analyzing a binlog, the system reads from the cache file to create a Workspace, providing a more stable and efficient solution.