Skip to content
This repository was archived by the owner on Apr 27, 2026. It is now read-only.

Recognize VS as a well known front end #3090

Merged
shyamnamboodiripad merged 2 commits into from
Jul 18, 2023
Merged

Recognize VS as a well known front end #3090

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56d407d
Recognize VS as a well known front end.
shyamnamboodiripad Jul 13, 2023
98d4a86
Improve match criteria to prevent false positives.
shyamnamboodiripad Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Microsoft.DotNet.Interactive.Telemetry/StartupTelemetryEventBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public sealed class StartupTelemetryEventBuilder
public StartupTelemetryEventBuilder(Func<string, string> hash)
{
_hash = hash ?? throw new ArgumentNullException(nameof(hash));

}

public IEnumerable<TelemetryEvent> GetTelemetryEventsFrom(ParseResult parseResult)
Expand Down Expand Up @@ -276,6 +276,12 @@ private static string GetFrontendName(
case "vscode":
return directive.Key;
}

if (directive.Key.StartsWith("vs") &&
int.TryParse(directive.Key.Substring(2), out _)) // VS appends the process id after the "vs" prefix.
{
return "vs";
Comment thread
shyamnamboodiripad marked this conversation as resolved.
}
}

switch (commandResult.Command.Name)
Expand Down