Skip to content
This repository was archived by the owner on Apr 27, 2026. It is now read-only.

Pass environment variable culture from Visual Studio/VSCode to command line processes#3054

Merged
ocallesp merged 6 commits into
dotnet:mainfrom
ocallesp:set-culture-in-command-line
Jun 28, 2023
Merged

Pass environment variable culture from Visual Studio/VSCode to command line processes#3054
ocallesp merged 6 commits into
dotnet:mainfrom
ocallesp:set-culture-in-command-line

Conversation

@ocallesp

@ocallesp ocallesp commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

This pull request aims to propagate the Culture and UICulture settings from Visual Studio and VS Code to the child processes responsible for executing the code (kernels).

Three new unit tests:

  • Culture_Is_Set_Based_On_Environment_Variable
  • UICulture_Is_Set_Based_On_Environment_Variable
  • Kernel_Execute_Code_Using_Culture_From_Parent_Thread_That_Created_It

Comment thread src/dotnet-interactive/Program.cs Outdated
Comment thread src/dotnet-interactive/Connection/StdIoKernelConnector.cs
@ocallesp
ocallesp marked this pull request as ready for review June 27, 2023 22:46
@ocallesp
ocallesp requested review from colombod and jonsequitur June 28, 2023 15:39
Comment thread src/dotnet-interactive.Tests/StdIoBehaviorTests.cs Outdated
Comment thread src/polyglot-notebooks-vscode-common/src/extension.ts
@ocallesp
ocallesp requested a review from jonsequitur June 28, 2023 19:48
@ocallesp
ocallesp enabled auto-merge June 28, 2023 20:44
@ocallesp
ocallesp merged commit 69a9616 into dotnet:main Jun 28, 2023
@ocallesp
ocallesp deleted the set-culture-in-command-line branch June 28, 2023 20:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants