Skip to content
This repository was archived by the owner on Apr 27, 2026. It is now read-only.

Improve handling for http responses that are too slow and / or too large#3052

Merged
shyamnamboodiripad merged 2 commits into
dotnet:mainfrom
shyamnamboodiripad:http
Jun 26, 2023
Merged

Improve handling for http responses that are too slow and / or too large#3052
shyamnamboodiripad merged 2 commits into
dotnet:mainfrom
shyamnamboodiripad:http

Conversation

@shyamnamboodiripad

Copy link
Copy Markdown
Contributor

Updates the HttpRequestKernel to send leading DisplayEvents with partial information when the complete http response is too slow and / or too large. These leading events are then used to drive progress display to improve end-user perceived performance.

This allows code in an external repo that links in this source file to compile without errors.
Comment thread src/Microsoft.DotNet.Interactive.HttpRequest/HttpRequestKernel.cs Outdated
Comment thread src/Microsoft.DotNet.Interactive/FormattedValue.cs Outdated
Comment thread src/Microsoft.DotNet.Interactive.HttpRequest.Tests/HttpRequestKernelTests.cs Outdated
…tml elements.Send leading display events with partial http responses when the actual http responses are either too slow or too large.

These leading events are then used to drive progress display to improve end-user perceived perormance.
@shyamnamboodiripad
shyamnamboodiripad merged commit 2ca13ba into dotnet:main Jun 26, 2023
@shyamnamboodiripad
shyamnamboodiripad deleted the http branch June 26, 2023 23:26
@colombod colombod added the Area-Formatting Data and object formatting as HTML and plaintext label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Area-Formatting Data and object formatting as HTML and plaintext

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants