This repository was archived by the owner on Apr 27, 2026. It is now read-only.
Align js#3011
Merged
Merged
Conversation
colombod
marked this pull request as ready for review
June 2, 2023 15:36
colombod
enabled auto-merge (rebase)
June 2, 2023 16:52
Member
Author
|
@brettfo can you tell me if the test retry logic in the ps file makes sense? |
jonsequitur
reviewed
Jun 2, 2023
|
|
||
| export class MockKernelCommandAndEventChannel { | ||
|
|
||
| private static _counter = 0; |
Contributor
There was a problem hiding this comment.
The monotonically incrementing integer has a high likelihood of colliding with the debug implementation of on the .NET side. Does this or equivalent ever run in the actual extension?
jonsequitur
approved these changes
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.