This repository was archived by the owner on Apr 27, 2026. It is now read-only.
Kernel Connector can return more than one kernel#2923
Merged
Conversation
AbhitejJohn
reviewed
Apr 19, 2023
| connector.CreateKernel = _createKernel; | ||
| return connector.CreateKernelAsync(commandLineContext.ParseResult.GetValueForOption(KernelNameOption)); | ||
| var kernel = await connector.CreateKernelAsync(commandLineContext.ParseResult.GetValueForOption(KernelNameOption)); | ||
| return new[] { kernel }; |
Contributor
There was a problem hiding this comment.
ah, this is an interesting pattern change. Seems like we'll now be waiting to create each kernel in the constructor. No concerns at the moment, just calling it out. I wonder if we could do IAsyncEnumerable. Dont know if we have netstandard constraints though (it only works 2.1 and above).
Contributor
There was a problem hiding this comment.
(We do have netstd concerns since the same code is compiled to netstd2.0 as well as part of the MS.DN.Interactive.VisualStudio.csproj)
update contract update contract
colombod
force-pushed
the
connect_multiple_kernels
branch
from
April 19, 2023 00:25
8ab2e5e to
b47850b
Compare
jonsequitur
approved these changes
Apr 19, 2023
colombod
added
the
breaking change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.