[release/10.0] Switch Microsoft.Data.Sqlite and EFCore.Sqlite to SQLite3MC.PCLRaw.bundle (backport #38402, #36551)#38546
Open
ViveliDuCh wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Backports the SQLite native-bundle switch and SQLitePCLRaw 3.x packaging changes to release/10.0, updating shipped Sqlite packages to use the SQLite3MC bundle (encryption-capable) by default and adjusting test coverage/projects accordingly.
Changes:
- Updated EFCore.Sqlite and Microsoft.Data.Sqlite to reference
SQLite3MC.PCLRaw.bundle, and added the corresponding centralized version plumbing. - Updated/reshaped the Microsoft.Data.Sqlite test matrix for SQLitePCLRaw 3.x (provider packages for OS-provided SQLite; removed deprecated crypto/OS bundle-based test projects; added
sqlite3mctests). - Updated solutions/filters and test projects (EFCore.Sqlite.FunctionalTests/EFCore.Design.Tests) to exercise the shipped SQLite3MC bundle in CI.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/Microsoft.Data.Sqlite.Tests/TestUtilities/SqliteTestFramework.cs | Adjusts test framework selection and adds provider-based init for winsqlite3/sqlite3. |
| test/Microsoft.Data.Sqlite.Tests/SqliteConnectionTest.cs | Updates preprocessor conditions to reflect the new SQLITE3MC test target. |
| test/Microsoft.Data.Sqlite.Tests/Microsoft.Data.Sqlite.winsqlite3.Tests.csproj | Switches from deprecated bundle package to core+provider packages. |
| test/Microsoft.Data.Sqlite.Tests/Microsoft.Data.Sqlite.Tests.csproj | Adds RID for netfx and continues to test the bundle_e_sqlite3 path. |
| test/Microsoft.Data.Sqlite.Tests/Microsoft.Data.Sqlite.sqlite3mc.Tests.csproj | Retargets the encryption-capable test project to SQLite3MC bundle and constant. |
| test/Microsoft.Data.Sqlite.Tests/Microsoft.Data.Sqlite.sqlite3.Tests.csproj | Switches from deprecated bundle package to core+provider packages. |
| test/Microsoft.Data.Sqlite.Tests/Microsoft.Data.Sqlite.e_sqlite3mc.Tests.csproj | Removes the deprecated bundle_e_sqlite3mc test project. |
| test/EFCore.Sqlite.FunctionalTests/EFCore.Sqlite.FunctionalTests.csproj | Runs provider functional tests against SQLite3MC bundle. |
| test/EFCore.Design.Tests/EFCore.Design.Tests.csproj | Runs design-time tests against SQLite3MC bundle. |
| test/Directory.Packages.props | Updates test-only package versions for SQLitePCLRaw 3.x provider packages. |
| src/Microsoft.Data.Sqlite/Microsoft.Data.Sqlite.csproj | Switches shipped Microsoft.Data.Sqlite to SQLite3MC bundle. |
| src/Microsoft.Data.Sqlite.Core/Properties/InternalsVisibleTo.cs | Updates friend assemblies to match new/removed test projects. |
| src/EFCore.Sqlite/EFCore.Sqlite.csproj | Switches shipped EFCore.Sqlite to SQLite3MC bundle. |
| Microsoft.Data.Sqlite.slnf | Updates solution filter to remove deprecated projects and include sqlite3mc tests. |
| eng/Versions.props | Bumps SQLitePCLRaw to 3.0.3 and introduces SQLite3MC bundle version property. |
| EFCore.sln | Removes deprecated test projects and adds sqlite3mc tests to the main solution. |
| Directory.Packages.props | Adds centralized SQLite3MC bundle version and removes deprecated bundle version entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the SQLite native bundle change (#38402, merged in 11.0 preview 6) to
release/10.0. See #38402 for the full rationale and dotnet/EntityFramework.Docs#5385 for the breaking-change docs.Because
release/10.0did not yet have the SQLitePCLRaw 3.x update (#36551 / #36535), this backport combines both changes:SQLitePCLRawVersionto3.0.3. The crypto and OS-provided bundles (bundle_e_sqlcipher,bundle_e_sqlite3mc,bundle_sqlite3,bundle_winsqlite3) are no longer published, so the affected test projects move to theSQLitePCLRaw.provider.*packages and thee_sqlcipher/e_sqlite3mctest projects are removed.Microsoft.Data.SqliteandMicrosoft.EntityFrameworkCore.Sqlitenow referenceSQLite3MC.PCLRaw.bundle(2.3.5) instead ofSQLitePCLRaw.bundle_e_sqlite3, shipping an encryption-capable (SQLite3 Multiple Ciphers) native build by default.Microsoft.Data.Sqlite.sqlite3mc.Testsproject and switchesEFCore.Sqlite.FunctionalTests/EFCore.Design.TeststoSQLite3MC.PCLRaw.bundleso CI exercises the shipped bundle.User-facing breaking-change behavior and migration guidance are documented in dotnet/EntityFramework.Docs#5385.
Links