Remove zlib-devel dependency from azurelinux for .NET 9.0#1125
Merged
Conversation
ghost
added
the
jkotas
reviewed
Jul 4, 2024
jkotas
added
the
do-not-merge
jkotas
approved these changes
Jul 4, 2024
jkotas
left a comment
jkotas
left a comment
Member
There was a problem hiding this comment.
We should wait a few weeks for the dust to settle before merging.
Contributor
Author
@jkotas How about I merge this on Monday August 12th? That's one day before we release P7. On the 13th we will start consuming P7 officially in our own repos. |
Member
This is nice-to-have cleanup. I think that doing this one day after we release P7 would make more sense, so that it cannot interfere with P7 release in any way by construction. |
Contributor
Author
|
P7 has already been released. We even snapped 9.0 already. So this should be safe to merge now. |
carlossanlop
removed
the
do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/runtime#101465
For .NET 9.0, we brought a copy of zlib-ng into dotnet/runtime that will be used by all platforms, except for the mobile ones (android, ios, tvos, maccatalyst) and armv6: dotnet/runtime#102403
For that reason, and as suggested in this comment, the azurelinux docker images that target .NET 9.0 won't need to install
zlib-develas a dependency anymore.