Skip to content

Fix SignalR token retry for thrown 401 errors#67899

Open
pradeep-ramola wants to merge 4 commits into
dotnet:mainfrom
pradeep-ramola:pradeep-ramola/signalr-retry-401-http-error
Open

Fix SignalR token retry for thrown 401 errors#67899
pradeep-ramola wants to merge 4 commits into
dotnet:mainfrom
pradeep-ramola:pradeep-ramola/signalr-retry-401-http-error

Conversation

@pradeep-ramola

Copy link
Copy Markdown

Jest: 2 test files passed, 26 tests passed
ESLint: touched test files passed
build:cjs: passed
build:esm: passed
git diff --check: passed

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Jul 20, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Thanks for your PR, @pradeep-ramola. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@pradeep-ramola

Copy link
Copy Markdown
Author

@pradeep-ramola please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

@gfoidl gfoidl added the area-signalr Includes: SignalR clients and servers label Jul 21, 2026
@gfoidl

gfoidl commented Jul 21, 2026

Copy link
Copy Markdown
Member

What's the difference to #67851?
Or why should this PR prefered over the other one?

@pradeep-ramola

Copy link
Copy Markdown
Author

What's the difference to #67851? Or why should this PR prefered over the other one?

Thanks for pointing this out.

You're right that #67851 covers the same core issue and was opened earlier. The main difference is that this PR adds coverage through the LongPolling/SSE transport paths, while #67851 focuses the tests directly on AccessTokenHttpClient and also extracts the shared retry logic into a helper.

I don't think this PR needs to be preferred over #67851. If the maintainers prefer to move forward with #67851, I'm happy to close this as a duplicate. If the extra transport-level coverage here is useful, I can also keep this open only as reference or follow up separately with that coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-signalr Includes: SignalR clients and servers community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants