Closed
Sign codeflow commits from PCS and verify them before auto-approval#6483
Conversation
Copilot
AI
changed the title
Sign codeflow commits from PCS and verify signatures before approval
Sign codeflow commits from PCS and verify them before auto-approval
Jul 7, 2026
Copilot created this pull request from a session on behalf of
dkurepa
July 7, 2026 20:39
View session
adamzip
reviewed
Jul 9, 2026
| IPullRequestApprover pullRequestApprover, | ||
| ICommitSignatureVerifier commitSignatureVerifier, | ||
| IProcessManager processManager, | ||
| ILogger<CodeFlowPullRequestUpdater> logger) |
Contributor
There was a problem hiding this comment.
@dkurepa PRUpdater is starting to have quite a huge number of dependencies, it could be good to try to keep it down if possible. There's 3-4 new dependencies that have to do with auto approvals. Maybe one of those services can be the "orchestrator" for the auto approval processor, like IPullRequestApprover, and that it would contain all the entry-points to the verification, approval, and signing methods that are needed in PullRequestUpdater. That could offload some of the weight off of PrUpdater
Member
There was a problem hiding this comment.
I'll keep that in mind.
Please don't waste time looking at this PR yet, it's just a draft made by the agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code flow PRs were previously treated as trustworthy based on commit author identity, which is easy to spoof. This change makes PCS-produced code flow commits cryptographically attributable to the service and requires those signatures to verify before the PR can be auto-approved.
Overview
Security impact