-
Notifications
You must be signed in to change notification settings - Fork 574
[Mono.Android] Abort in-flight body I/O on response dispose #12105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simonrozsival
wants to merge
12
commits into
main
Choose a base branch
from
fix/69464-response-dispose-race
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+468
−40
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a1541ec
[Mono.Android] Serialize response stream disposal
simonrozsival 3c2a685
[Mono.Android] Abort in-flight body I/O on response dispose
simonrozsival 0e046b0
[Mono.Android] Use XML doc comments for type/member documentation
simonrozsival d3ccc4c
[Mono.Android] Skip redundant abort when disposing with no active ope…
simonrozsival 9f20629
[Mono.Android] Consolidate drain-safety bracket into helper methods
simonrozsival 36af21b
[Mono.Android] Simplify drain state to one flag and unify RunOperation
simonrozsival 7f65597
[Mono.Android] Disconnect synchronously in AndroidHttpResponseMessage…
simonrozsival 6176a21
[Mono.Android] Restore explicit 'disposed' flag for teardown guard
simonrozsival 8301d76
[Mono.Android] Make RunOperation Task-based instead of ValueTask
simonrozsival 21b9244
[Mono.Android] Keep response stream private; unify RunOperation bracket
simonrozsival 8583cfa
[Mono.Android] Avoid response read cancellation allocations
simonrozsival 5b83687
Merge branch 'main' into fix/69464-response-dispose-race
simonrozsival File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖⚠️ Documentation — Two rationales in this PR conflict about running
HttpURLConnection.Disconnect()on the (possibly UI) disposing thread. Here the comment says the synchronousDisconnect()is safe on the UI thread because "closing a socket ... does not triggerNetworkOnMainThreadException", yetCancellationAwareResponseStream.RequestDisconnectgoes out of its way to background the very same call because "Disconnect()performs socket I/O that must not run there." Both can't be true — please reconcile.Relatedly, the comment on the lines above ("for a streaming response the content already disconnected via
base.Disposeabove") is inaccurate for the in-flight case: when a body read is parked,base.Disposeonly schedules a backgrounded disconnect and defers the close, so this synchronousDisconnect()is frequently the call that actually aborts the parked read — on the disposing thread. Worth clarifying so the "Dispose()never blocks" invariant in the class docs isn't misleading.(Verify: same
httpConnectionpeer is shared byAndroidHttpResponseMessageandCancellationAwareResponseStream.)