Skip to content

[tests] Disable flaky UnregisterFromRuntime peer-count test#12037

Merged
jonathanpeppers merged 1 commit into
mainfrom
dev/simonrozsival/disable-flaky-unregister-peer-count
Jul 13, 2026
Merged

[tests] Disable flaky UnregisterFromRuntime peer-count test#12037
jonathanpeppers merged 1 commit into
mainfrom
dev/simonrozsival/disable-flaky-unregister-peer-count

Conversation

@simonrozsival

Copy link
Copy Markdown
Member

Temporarily ignores JavaObjectTest.UnregisterFromRuntime, which intermittently fails when the process-wide surfaced-peer count changes while the assertion is running.

This has the same shared-process isolation problem as the GREF assertion disabled in #12032. Issue #12031 now tracks both affected tests and the proposal to move reference/peer leak checks into a dedicated device test process with controlled lifecycle and concurrency.

Example failure: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1504514&view=results

Temporarily ignore the process-wide peer-count assertion while #12031 tracks an isolated leak-test harness.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7be7d34c-aff3-4338-b15b-6061bc7a3ba9
Copilot AI review requested due to automatic review settings July 11, 2026 13:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables a flaky JavaObjectTest.UnregisterFromRuntime on-device test in Java.Interop by marking it ignored, aligning with the existing approach used to suppress similar process-wide leak/peer-count flakiness tracked in #12031.

Changes:

  • Mark JavaObjectTest.UnregisterFromRuntime with [Ignore] and link to the tracking issue for the known flakiness.
Show a summary per file
File Description
external/Java.Interop/tests/Java.Interop-Tests/Java.Interop/JavaObjectTest.cs Ignores UnregisterFromRuntime due to known process-wide surfaced-peer count flakiness tracked in #12031.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@simonrozsival simonrozsival added the ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable). label Jul 11, 2026
@jonathanpeppers
jonathanpeppers merged commit b8906b5 into main Jul 13, 2026
43 checks passed
@jonathanpeppers
jonathanpeppers deleted the dev/simonrozsival/disable-flaky-unregister-peer-count branch July 13, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky-tests ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants