Move to Shared -SqlDataRecord#1309
Merged
DavoudEshtehari merged 10 commits intoOct 13, 2021
Merged
Conversation
this is part of dotnet#1261 issue code merge classes. Moved the SqlDataRecord common code to .Common.cs class and insternally invoked private methods from corresponsding FrameworkSpecific methods.
|
|
DavoudEshtehari
added
the
Code Health 💊
DavoudEshtehari
left a comment
DavoudEshtehari
left a comment
Contributor
There was a problem hiding this comment.
Good job! just some minor improvements; remove unused namespaces and extra blank lines.
Removed blankspaces, unused namespaces.
Removing extra spaces and unused namespaces
Identatation and split into two lines for long lines
Contributor
Author
@DavoudEshtehari Thanks Davoud, I have made the changes. |
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
DavoudEshtehari
approved these changes
Oct 6, 2021
johnnypham
approved these changes
Oct 6, 2021
Contributor
|
Nit: some members in the common file can be changed to expression-bodied members. |
updated methods to use Expression bodied members
Contributor
Author
Thanks Johnny, I updated wherever VS suggested. |
Moved netcore and netfx files to common folder for consistency sake
Removed Common from file name SqlDataRecord
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #1261 issue code merge classes. Moved the SqlDataRecord common code to .Common.cs class and insternally invoked private methods from corresponsding FrameworkSpecific methods.