Skip to content

Merging common code bases StringsHelper#1288

Merged
DavoudEshtehari merged 4 commits into
dotnet:mainfrom
DavoudEshtehari:Adhoc/MergeStringsHelper
Sep 29, 2021
Merged

Merging common code bases StringsHelper#1288
DavoudEshtehari merged 4 commits into
dotnet:mainfrom
DavoudEshtehari:Adhoc/MergeStringsHelper

Conversation

@DavoudEshtehari

Copy link
Copy Markdown
Contributor

@DavoudEshtehari DavoudEshtehari added the Code Health 💊 Issues/PRs that are targeted to source code quality improvements. label Sep 25, 2021
@DavoudEshtehari DavoudEshtehari added this to the 4.0.0-preview3 milestone Sep 25, 2021

@lcheunglci lcheunglci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Comment thread src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj Outdated
Comment thread src/Microsoft.Data.SqlClient/src/Resources/StringsHelper.cs Outdated
Comment thread src/Microsoft.Data.SqlClient/src/Resources/StringsHelper.cs
@DavoudEshtehari
DavoudEshtehari merged commit f59d1c7 into dotnet:main Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Health 💊 Issues/PRs that are targeted to source code quality improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants