Add $pop tests#603
Conversation
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, test-framework); effort from diff stats (603+1 LOC, 7 files); LLM: Adds new test cases for the $pop array update operator, expanding compatibility test coverage. If a label is wrong, remove it manually and ping |
| ] | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("test", pytest_params(TESTS + UPSERT_TESTS)) |
There was a problem hiding this comment.
[Minor] pytest_params(TESTS + UPSERT_TESTS) mixes general-behavior and upsert cases through one runner that branches on test.upsert. Splitting into two parametrize calls (or two named runners) would give clearer test IDs and let upsert-specific invariants be asserted without per-case branching.
|
|
||
|
|
||
| @pytest.mark.parametrize("test", pytest_params(POP_COMBINATION_TESTS)) | ||
| def test_pop_combination(collection, test: UpdateTestCase): |
There was a problem hiding this comment.
[Minor] test_pop_combination duplicates the body of test_positional_query_operators above (insert → run update → find → assert). Since POP_COMBINATION_TESTS is the same list[UpdateTestCase] shape, consider merging into a single parametrize+runner or extracting a small helper to avoid the copy.
This PR adds the tests for the $pop array update operator.
Ref: Issue #36, #381