Skip to content

Add $planCacheClearFilters command tests#583

Open
alinaliBQ wants to merge 4 commits into
documentdb:mainfrom
alinaliBQ:planCacheClearFilters
Open

Add $planCacheClearFilters command tests#583
alinaliBQ wants to merge 4 commits into
documentdb:mainfrom
alinaliBQ:planCacheClearFilters

Conversation

@alinaliBQ

@alinaliBQ alinaliBQ commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This change adds tests for the $planCacheClearFilters command operator.

Add command operator tests for $planCacheClearFilters. Tests database $planCacheClearFilters behavior, syntax, and expected errors.

@alinaliBQ alinaliBQ force-pushed the planCacheClearFilters branch from 79812e8 to 1ed75ec Compare June 9, 2026 20:03
@alinaliBQ alinaliBQ marked this pull request as ready for review June 9, 2026 20:03
@alinaliBQ alinaliBQ requested a review from a team as a code owner June 9, 2026 20:03
@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jun 9, 2026
@documentdb-triage-tool

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status Needs Review
Confidence: 0.82 (mixed)

Reasoning

component from path globs (test-coverage); effort from diff stats (809+0 LOC, 5 files); LLM: Adds new test coverage for the $planCacheClearFilters command operator, covering behavior, syntax, and error cases — a functional test addition with moderate scope.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@alinaliBQ alinaliBQ changed the title Add $planCacheClearFilters command tests Add $planCacheClearFilter command tests Jun 9, 2026
@alinaliBQ alinaliBQ changed the title Add $planCacheClearFilter command tests Add $planCacheClearFilters command tests Jun 9, 2026
@@ -0,0 +1,291 @@
"""Tests for planCacheClearFilters command core behavior."""

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to actually verify if the index filter is removed by this command and not just check if the index filter command gives OK.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I have added test_planCacheClearFilters_behavior.py to test

@alinaliBQ alinaliBQ force-pushed the planCacheClearFilters branch from 1ed75ec to 1bec02a Compare June 11, 2026 19:56
@alinaliBQ alinaliBQ requested a review from Rishabh998 June 11, 2026 20:40
apply style-guide.md

add init.py

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>

split success and error cases

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>

merge files

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>

merge error files

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ alinaliBQ force-pushed the planCacheClearFilters branch from d84a440 to 2121462 Compare June 12, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants