Skip to content

ci: skip windows release checksums and sigstore bundles #3978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crazy-max merged 1 commit into from
Jul 28, 2026
+2 −2
Merged

ci: skip windows release checksums and sigstore bundles #3978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ jobs:
mv "provenance.json" "${filename}.provenance.json"
mv "sbom-binaries.spdx.json" "${filename}.sbom.json"
find . -name 'sbom*.json' -exec rm {} \;
if [[ "$binname" == *darwin* ]]; then
if [[ "$binname" == *darwin* ]] || [[ "$binname" == *windows* ]]; then

@thaJeztah thaJeztah Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have tracking issues for the remaining work for this? (wondering if a TODO + link is warranted here)

@crazy-max crazy-max Jul 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No public tracking issue that I know of yet. The intent here is to match the existing Darwin flow because Windows binaries will now be signed by the downstream workflow after the Buildx release assets are uploaded, so we should not publish checksums for the unsigned Windows binaries that will be replaced.

I will look to add something in our README.

rm -f "provenance.sigstore.json"
elif [ -f "provenance.sigstore.json" ]; then
mv "provenance.sigstore.json" "${filename}.sigstore.json"
Expand All @@ -350,7 +350,7 @@ jobs:
working-directory: ${{ env.DESTDIR }}
run: |
sha256sum -b buildx-* > ./checksums.txt
sed -i '/darwin/d' ./checksums.txt
sed -i -e '/darwin/d' -e '/windows/d' ./checksums.txt
sha256sum -c --strict checksums.txt
-
name: List artifacts
Expand Down
Loading