Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Change nsinit root to /var/run/nsinit#507

Merged
crosbymichael merged 1 commit into
docker-archive:masterfrom
crosbymichael:nsinit-root
Apr 3, 2015
Merged

Change nsinit root to /var/run/nsinit#507
crosbymichael merged 1 commit into
docker-archive:masterfrom
crosbymichael:nsinit-root

Conversation

@crosbymichael

Copy link
Copy Markdown
Contributor

Signed-off-by: Michael Crosby crosbymichael@gmail.com

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@mrunalp

mrunalp commented Apr 3, 2015

Copy link
Copy Markdown
Contributor

LGTM

crosbymichael added a commit that referenced this pull request Apr 3, 2015
Change nsinit root to /var/run/nsinit
@crosbymichael crosbymichael merged commit 346236b into docker-archive:master Apr 3, 2015
@crosbymichael crosbymichael deleted the nsinit-root branch April 3, 2015 17:50
@SaiedKazemi

Copy link
Copy Markdown

@crosbymichael @avagin
LGTM. Although now I understand how it works, it's a good idea to change the default value so others won't be confused.
By the way, I think the Checkpoint() and Restore() APIs will be more flexible if the CRIU images directory was passed in. If nil is passed in, it can use filepath.Join(c.root, "checkpoint"). But if it's set to a particular path, that would be the images directory to use.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants