Hardcode default timeout to 120000 - #26
Merged
Merged
Conversation
aeden
approved these changes
Feb 24, 2020
Member
|
Thank you for the PR @jonchurch. I'll have @weppos look over it in the morning and get it merged in to master. |
weppos
approved these changes
Feb 25, 2020
weppos
left a comment
weppos
left a comment
Member
There was a problem hiding this comment.
Thanks!
As a side note, I question 120 seconds being a reasonable default timeout (given our system actually timeouts at a far lower value), but that's outside the scope of this PR which I'll happily merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Node.js v13 this value has been changed to
0. Hardcoding it to previous value will preserve behavior under Node.js v13Closes #25