fix(config): remove nested none values before toml serialization#4249
Open
mattfaltyn wants to merge 2 commits into
Open
fix(config): remove nested none values before toml serialization#4249mattfaltyn wants to merge 2 commits into
mattfaltyn wants to merge 2 commits into
Conversation
mattfaltyn
marked this pull request as ready for review
July 17, 2026 09:15
mattfaltyn
marked this pull request as draft
July 17, 2026 09:41
mattfaltyn
marked this pull request as ready for review
July 17, 2026 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Nonevalues from nested mappings before TOML serialization_config_docand_config_tomlstay synchronizedRelated Issues
Additional Context
BaseDocProvider._set_valuepreviously removedNoneonly from the outer dictionary. NestedNonevalues reached tomlkit, causingStringTomlProvider.dumps()to raise_ConvertError.SettingsTomlProvidercaught that conversion error but still updated its plain dictionary, so the value appeared in memory while being omitted from persisted TOML.The fix sanitizes values in the shared provider path before either representation is updated. Tuple inputs are normalized to lists because tomlkit represents TOML arrays as lists; this also avoids reconstructing tuple subclasses with incompatible constructors.
Validation
make lint— passed, including mypy, Ruff, Flake8, Bandit, lockfile, dependency, and API compatibility checkspython -m pytest tests/common/configuration/test_toml_provider.py -q— 20 passedpython -m pytest tests/common/configuration -q— 247 passed, 11 skippedload_githubexample exhausting GitHub's 60-request unauthenticated API quota while fetching issue commentspytest-forkedharness stalled; the isolated five-test tail then passed