[compliance tests] addresses timeouts on the server side - #712
Merged
Merged
Conversation
…metadata decoding errors which are translated to a BadRequest http4s response and deferred.complete is never called
Baccata
reviewed
Jan 9, 2023
Baccata
changed the title
Contributor
|
Additionally : when you create a PR, please be mindful of the public nature of the project : people who aren't familiar with the project might open the pull-request list. You should be as precise in the titles of your PR as possible, and try to describe the problem in a way that random people reading may have a chance of understanding it. |
daddykotex
approved these changes
Jan 9, 2023
daddykotex
left a comment
daddykotex
left a comment
Contributor
There was a problem hiding this comment.
Good job
For future self, this PR is related to #708
lewisjkl
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which are caused by payload or metadata decoding errors which are translated into an http4s response and deferred.complete is never called.
This causes the real error to remain hidden