#2: i18n by PaulineNemchak · Pull Request #9 · dimidiumlabs/mirum

PaulineNemchak · 2026-04-13T16:41:59Z

Closes #2

adds internationalisation, currently only for en (US) and en (GB) with GB as a default;
saves preferences to the DB;

mrdimidium

I also don't understand why you're committing the generated code? Is there a reason it wasn't included in gitignore?

mrdimidium · 2026-04-13T16:51:40Z

 		ALTER TABLE workers DISABLE ROW LEVEL SECURITY;
 	`)

+	migrator.AppendMigration("add_user_settings", `


There may be more locale settings, it's more convenient to store them all in a single locale column with a custom type.

For languages, don't validate here: adding a locale will require migration.

Regarding the date/time format, don't store the format string. There are about three formats; store a simple enum here that specifies the type.

Fot timezone postgres already has validator: https://www.postgresql.org/docs/9.2/view-pg-timezone-names.html

mrdimidium · 2026-04-13T16:51:53Z

  rpc WorkerList(WorkerListRequest) returns (WorkerListResponse);
  rpc WorkerDelete(WorkerDeleteRequest) returns (WorkerDeleteResponse);
+
+  rpc UserSettingsUpdate(UserSettingsUpdateRequest) returns (UserSettingsUpdateResponse);


You already have UserUpdate method

PaulineNemchak · 2026-04-13T17:11:37Z

I also don't understand why you're committing the generated code? Is there a reason it wasn't included in gitignore?

I thought it's needed

mrdimidium · 2026-04-13T17:15:24Z

@PaulineNemchak, I would try to remove the generated files in gitignore (as we already do with proto).

mrdimidium · 2026-04-15T22:15:08Z

  }];
 }
 message WorkerDeleteResponse {}
+


No need to mess up the formatting

mrdimidium · 2026-04-15T22:16:10Z

  optional string email = 2 [(buf.validate.field).string.email = true];
  optional string password = 3 [(buf.validate.field).string.min_len = 1];
+  optional string locale = 4 [(buf.validate.field).string = {
+    in: ["en-GB", "en-US"]


As with db, the check here only gets in the way and requires updating the API when a language is added. It's just a string.

mrdimidium · 2026-04-15T22:18:51Z

+    env:
+      CGO_ENABLED: "1" # required for -race
+    cmds:
+      - go test -race -count=1 ./...


Why is it here?

mrdimidium · 2026-04-15T22:20:58Z

 		return
 	}

+	if locale := parseLocale(r.Header.Get("Accept-Language")); locale != "" {


Not exactly. You define a title for each page if the database doesn't have a value for it, rather than storing one upon login.

mrdimidium · 2026-04-15T22:21:48Z

+func parseLocale(acceptLang string) string {
+	for _, part := range strings.Split(acceptLang, ",") {
+		tag := strings.TrimSpace(strings.SplitN(part, ";", 2)[0])
+		if strings.HasPrefix(tag, "en-US") {


You need a value parser (there may be several with weights), and not just a switch-case

mrdimidium · 2026-04-15T22:23:08Z

+// For unauthenticated actors no DB call is made.
+func localeFor(ctx context.Context, actor Actor, db *DB) string {
+	if actor.Kind() == KindUser {
+		if u, err := db.UserGet(ctx, actor, UserByID(actor.UserID())); err == nil && u.Locale != nil {


I don't think you need a separate request here, Actor is already a user, expand it.

mrdimidium · 2026-04-16T21:41:44Z

+            linux-ppc64le,
+            linux-loong64,
+            linux-s390x,
+          ]


What are these changes for?

mrdimidium · 2026-04-17T01:31:41Z

  optional string email = 2 [(buf.validate.field).string.email = true];
  optional string password = 3 [(buf.validate.field).string.min_len = 1];
+  optional string locale = 4 [(buf.validate.field).string.max_len = 32];
+  optional string date_format = 5 [(buf.validate.field).string = {


I think it's not a string, but an enum. String validation also don't required in proto files

mrdimidium · 2026-04-17T01:35:25Z

  bytes id = 1;
  string email = 2;
  google.protobuf.Timestamp created_at = 3;
+  optional string locale = 4;


Like in a database locale should be an object

mrdimidium · 2026-04-17T01:40:42Z

 // Invalidates all sessions when password changes.
-func (db *DB) UserUpdate(ctx context.Context, actor Actor, ref UserRef, email *string, password *string, pepper []byte) error {
-	if email == nil && password == nil {
+func (db *DB) UserUpdate(ctx context.Context, actor Actor, ref UserRef, email *string, password *string, pepper []byte, locale, dateFormat, timezone *string) error {


Create an props object for aguments

mrdimidium · 2026-04-17T01:43:43Z

-			if password != nil {
-				if _, err := tx.Exec(ctx, `DELETE FROM sessions WHERE user_id = $1`, id); err != nil {
+			if locale != nil || dateFormat != nil || timezone != nil {
+				if _, err := tx.Exec(ctx,


It's more reliable prepare one sql request, use builder

mrdimidium · 2026-04-17T01:44:51Z


+// UserSettingsInit sets locale on first login from browser hints.
+// Only updates columns that are still NULL — never overwrites a user-chosen value.
+func (db *DB) UserSettingsInit(ctx context.Context, actor Actor, id UserID, locale string) error {


You shouldn't init user locale after login, use default from browser if it wasn't redefined in user settings

mrdimidium · 2026-04-17T01:49:37Z

+		return
+	}
+	data := map[string]any{
 		"user": map[string]string{"email": actor.Email()},


Just save user object to "user", without flatten fields

mrdimidium · 2026-04-23T12:05:56Z

+  DateFormat date_format = 2;
+}

 message User {


Suggested change

message User {

message User {

bytes id = 1;

string email = 2;

google.protobuf.Timestamp created_at = 3;

optional Locale locale = 4;

optional string timezone = 5;

}

PaulineNemchak · 2026-04-23T17:44:26Z

+type DateFormat string
+
+const (
+	DateFormatDMY DateFormat = "dmy"


change to numbers

PaulineNemchak · 2026-04-23T17:46:10Z

+// LocaleSettings holds a user's language and date-format preferences,
+// stored as a composite column in the database.
+type LocaleSettings struct {
+	Language   *string


they are not optional

PaulineNemchak · 2026-04-23T17:48:07Z

+type UserUpdateParams struct {
+	Email    *string
+	Password *string
+	Pepper   []byte


user doesn't have pepper

PaulineNemchak · 2026-04-23T17:49:48Z

+		CREATE TYPE locale_settings AS (
+			language    TEXT,
+			date_format date_format_t,
+			timezone    timezone_t


PaulineNemchak · 2026-04-23T17:50:48Z

+		);
+		ALTER TABLE users ADD COLUMN locale locale_settings;
+	`, `
+		ALTER TABLE users DROP COLUMN locale;


add to existing table instead

PaulineNemchak · 2026-04-23T17:51:24Z

 	`)

+	migrator.AppendMigration("add_user_settings", `
+		CREATE DOMAIN timezone_t AS TEXT


PaulineNemchak · 2026-04-23T17:53:34Z

-// UserUpdate updates a user's email and/or password.
+// UserUpdate updates a user's email, password, and/or preferences.
 // Invalidates all sessions when password changes.
-func (db *DB) UserUpdate(ctx context.Context, actor Actor, ref UserRef, email *string, password *string, pepper []byte) error {


returt pepper

PaulineNemchak · 2026-04-23T17:56:49Z

 // licenses serves /about/licenses. Public: no auth, no CSRF.
-func (h *webHandler) licenses(w http.ResponseWriter, _ *http.Request) {
-	h.assets.renderPage(w, "licenses", http.StatusOK, licensesData)
+func (h *webHandler) licenses(w http.ResponseWriter, r *http.Request) {


write middleware instead

PaulineNemchak self-assigned this Apr 13, 2026

PaulineNemchak requested a review from mrdimidium as a code owner April 13, 2026 16:42

PaulineNemchak added the enhancement New feature or request label Apr 13, 2026

mrdimidium requested changes Apr 13, 2026

View reviewed changes

PaulineNemchak force-pushed the i18n branch 6 times, most recently from 0ce0bf3 to b6f7e74 Compare April 15, 2026 21:42

mrdimidium reviewed Apr 15, 2026

View reviewed changes

PaulineNemchak force-pushed the i18n branch 10 times, most recently from d72f10a to 9b6eb63 Compare April 16, 2026 20:02

mrdimidium reviewed Apr 16, 2026

View reviewed changes

Comment thread Taskfile.yml Outdated

linux-ppc64le,

linux-loong64,

linux-s390x,

]

mrdimidium Apr 16, 2026

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these changes for?

PaulineNemchak force-pushed the i18n branch from 9b6eb63 to 4a48466 Compare April 17, 2026 01:24

mrdimidium reviewed Apr 17, 2026

View reviewed changes

PaulineNemchak force-pushed the i18n branch 2 times, most recently from 4b3ac73 to 9376647 Compare April 17, 2026 02:46

mrdimidium force-pushed the main branch from b56db41 to c22bf6c Compare April 17, 2026 05:56

PaulineNemchak force-pushed the i18n branch 9 times, most recently from 8c45420 to 3291adf Compare April 18, 2026 00:38

Setup i18n infra

eec3535

PaulineNemchak force-pushed the i18n branch from 3291adf to eec3535 Compare April 23, 2026 00:22

mrdimidium reviewed Apr 23, 2026

View reviewed changes

PaulineNemchak commented Apr 23, 2026

View reviewed changes

mrdimidium force-pushed the main branch from ae4ab42 to 10a73f3 Compare May 17, 2026 03:13

Uh oh!

Conversation

PaulineNemchak commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrdimidium left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PaulineNemchak commented Apr 13, 2026

Uh oh!

mrdimidium commented Apr 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrdimidium Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PaulineNemchak commented Apr 13, 2026 •

edited

Loading

mrdimidium Apr 17, 2026 •

edited

Loading