feat(release-index): pin changelog base for the 2026-07-23 security hotfixes - #2105
Merged
Merged
Conversation
…otfixes
Both security hotfix versions of rc--2026-07-23_04-21 were letting
find_base_release() pick their changelog base. Pin it explicitly:
security-hotfix -> rc--2026-07-17_04-19 / base
(a268b428dde2317819a15f5ab9123ffa3b9719e9)
deterministic-tracker-security-hotfix -> rc--2026-07-23_04-21 / security-hotfix
(0c121276f3156e97de98151d5f6bec6b73695f9f)
changelog_base references another (rc_name, name) pair in the index rather
than a raw commit, and is keyed per OS variant. Only GuestOS is set: HostOS
is processed solely for a release's base version (v_idx == 0 in
reconciler.py), so a HostOS override on these two would be dead config.
pietrodimarco-dfinity
enabled auto-merge (squash)
July 27, 2026 16:41
NikolaMilosa
approved these changes
Jul 27, 2026
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin
changelog_basefor the two security hotfix versions ofrc--2026-07-23_04-21, which were previously lettingfind_base_release()choose:security-hotfix0c121276f3rc--2026-07-17_04-19/basea268b428dde2317819a15f5ab9123ffa3b9719e9deterministic-tracker-security-hotfixbd3d261559rc--2026-07-23_04-21/security-hotfix0c121276f3156e97de98151d5f6bec6b73695f9fNotes on the shape
changelog_baserefers to another(rc_name, name)entry in the index, not a raw commit, and it is keyed per OS variant. reconciler.py:711 resolves it withindex.root.version(rc_name, name)and raisesKeyErroron a miss — a typo is a hard reconciler failure, not a silent fallback. Both targets already exist in the index.Only
GuestOSis set. HostOS is processed solely for a release's base version (if os_kind == GUESTOS or v_idx == 0), and these are versions 3 and 4 in the block, so aHostOS:override would be dead config.deterministic-tracker-security-hotfixreferencingsecurity-hotfixwithin the same RC is fine — resolution is a flat index lookup, not a graph walk.Verification
Validated against both
release-index-schema.jsonand the generated pydantic model, resolving each base exactly the way the reconciler does. The diff is additive only — every other entry byte-identical.Release notes for both versions were already generated and uploaded on the base
find_base_release()picked. Two existence-only guards mean this config will be ignored while those drafts exist:if markdown_file(release_commit, os_kind)short-circuits past the whole changelog block;changelog_baseis only read in theelse.ensure()returns the existing doc untouched.Drive lookup is a title substring match on
{os_kind} Release Notes - {release_tag} ({release_commit}), keyed on the release commit. The base is not in the title, so changing it cannot invalidate the doc. The live log confirms the short-circuit is active:So: merge this first, then delete the two docs from Drive folder
1y-nuH29Gd5Err3pazYH6-LzcDShcOIFf:GuestOS Release Notes - release-2026-07-23_04-21-security-hotfix (0c121276f3156e97de98151d5f6bec6b73695f9f)GuestOS Release Notes - release-2026-07-23_04-21-deterministic-tracker-security-hotfix (bd3d261559a96ef4f55521111527b5e2ff6242a6)Order matters: the reconciler polls continuously, so deleting before this merges just regenerates them on the old base.
🤖 Generated with Claude Code