fix(release-controller): resubmit failed GuestOS election 142125 - #2044
Merged
Merged
Conversation
Proposal 142125 (electing GuestOS base b95f4a32b41798de115aac9298b51dd1662f1da5 for rc--2026-06-04_04-52) FAILED because its auto-computed retire list included 62e841d27ea12451f504e74c54843b7cbf93ca4d, which was still deployed to a subnet at execution time, so the registry trapped on the retirement and the new version was never elected. All subnets have since been upgraded off 62e841d..., so retiring it is now legal. The reconciler treats the FAILED proposal as already submitted and will not resubmit on its own, so add 142125 to ignored_proposals to force a fresh election proposal on the next cycle. The entry should be removed once the replacement proposal has been submitted.
pietrodimarco-dfinity
enabled auto-merge (squash)
June 8, 2026 16:56
r-birkner
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add NNS proposal
142125to the top-levelignored_proposalslist inrelease-index.yamlso the release controller resubmits the GuestOS election for baseb95f4a32b41798de115aac9298b51dd1662f1da5(rc--2026-06-04_04-52).Why
Proposal 142125 (
ReviseElectedGuestosVersions) FAILED on execution:The proposal elects
b95f4a32…and carries an auto-computed retire list (fa3e237…,f31310f…,c755244…,62e841d…).62e841d…(rc--2026-05-07_04-27) was still deployed to a subnet at execution time, so the registry trapped on the retirement and — because the proposal is atomic —b95f4a32…was never elected.62e841d…ended up in the retire list becauseversions_to_unelect()derives the active-release window from the Prometheus> 10nodes "active versions" query; the subnet still on62e841d…had too few reporting nodes to register as active.The sibling proposal 142127 (electing the
canister-loggingvariantfb721da…) executed fine because non-base variants get no retire list.Why it is now safe to resubmit
All 49 subnets have since been upgraded off
62e841d…(currently all ona47e5434…), so retiring it is now legal. The reconciler treats the FAILED proposal as "already submitted" and will not resubmit on its own;ignored_proposalsforces it to forget 142125 and submit a fresh election on the next cycle (no redeploy required).Follow-up
b95f4a32…is submitted, remove the142125entry fromignored_proposals.Notes
release-index-schema.json(ignored_proposalsis an integer array).