fix(bazel): repin Cargo.Bazel.lock after #2040 manifest update - #2042
Merged
Conversation
PR #2040 updated Cargo.toml/Cargo.lock without regenerating the Bazel crate lockfile, leaving crate_index_dre's digest stale and breaking `bazel build`/`bazel test` on main (and the v0.7.8 release pipeline) with "lockfile is out of date". Regenerate via CARGO_BAZEL_REPIN=true.
pietrodimarco-dfinity
enabled auto-merge (squash)
June 8, 2026 15:20
The ic-nns-governance-api bump in #2040 added a `success_value` field to ProposalInfo. The main code path (proposal.rs) was updated, but the test-only `gen_test_proposal` constructor was missed, breaking the build once the Bazel lockfile is repinned. Initialize it to None.
Contributor
Author
|
Pushed a second commit: the lockfile repin exposed a real compile break that the stale lockfile was masking — #2040 added |
pietrodimarco-dfinity
disabled auto-merge
June 8, 2026 15:36
r-birkner
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regenerate
Cargo.Bazel.lock(crate_index_dre) viaCARGO_BAZEL_REPIN=true bazel sync.Why
PR #2040 ("fix(registry): support NodeRewardType type4.1-4.5") updated
Cargo.tomlandCargo.lockbut did not repin the Bazel crate lockfile. This leftcrate_index_dre's recorded digest stale, so Bazel fails at repo fetch with:This has been breaking
mainCI ("Build and test", "Required checks") since #2040 merged, and it also blocks thev0.7.8release pipeline (itstestjob runsbazel testwithout repin).Verification
bazel query //rs/cli:drenow resolves cleanly without the digest mismatch.