fix(release): run mk-release.py before macOS DRE build - #1954
Merged
Conversation
…pes from release notes The canister path filter regex was excluding changes to files like `canister_http.rs` and `management_canister_types/`, which are core replica components. Add `_http` and `_types` to the negative lookahead so these paths are no longer filtered out. Made-with: Cursor
Tag-triggered releases need version strings updated in-tree before cargo build; align the macOS job with that step. Made-with: Cursor
pietrodimarco-dfinity
enabled auto-merge (squash)
April 1, 2026 14:37
severin-amrein
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The tag-triggered Release DRE binary workflow builds DRE on macOS after checkout, but the in-repo version metadata was not updated before
cargo build. This adds the same Update tags in code step used elsewhere: runbin/mk-release.pywith the pushed tag (${GITHUB_REF#refs/tags/}) so the binary is built with the correct release version.