refactor: remove automock to prevent must_use warnings for impl - #1843
Merged
Conversation
severin-amrein
marked this pull request as draft
December 10, 2025 08:10
severin-amrein
force-pushed
the
sev/refactor-must-use
branch
from
December 15, 2025 09:37
aa4130c to
5a29eb1
Compare
severin-amrein
marked this pull request as ready for review
December 15, 2025 09:49
NikolaMilosa
approved these changes
Dec 15, 2025
NikolaMilosa
left a comment
Contributor
There was a problem hiding this comment.
Automock is used for testing.
Given that we don't have tests with this, and the CI is green I see no issues with merging this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was caused by warnings of the following structure:
They are caused by using
automockthat automatically creates mock impl includingmust_use. Since the mock functions are not used at the moment, this PR removesautomock.