Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions release-controller/release_notes_composer.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ class Team:
r"rs\/nns.+",
r"test",
r"^bazel",
r"boundary",
r"rosetta",
r"pocket[_-]ic",
r"^Cargo.lock$",
Expand Down Expand Up @@ -440,8 +439,10 @@ def compose_change_description(
e.stderr,
)
raise
except subprocess.TimeoutExpired as e:
_LOGGER.error("Timeout determining codeowners for %s", change["file_path"])
except subprocess.TimeoutExpired:
_LOGGER.error(
"Timeout determining codeowners for %s", change["file_path"]
)
raise

# Because the first thing is the path being queried
Expand All @@ -457,7 +458,9 @@ def compose_change_description(
else owner
for owner in owners
]
owners = ["unknown" if "(unowned)" == owner else owner for owner in owners]
owners = [
"unknown" if "(unowned)" == owner else owner for owner in owners
]

teams = set(owners)

Expand Down
2 changes: 1 addition & 1 deletion release-controller/tests/test_reconciler_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@ def test_reconciler_publishes_tentative_changelog_when_changelog_not_yet_approve
## Excluded Changes

### Changed files are excluded by file path filter
* [`a21d0e6a3`](https://github.com/dfinity/ic/commit/a21d0e6a3) Boundary Nodes: add aliases for request type variants for backwards compatibility ([#7032](https://github.com/dfinity/ic/pull/7032))
* [`1e4faccbc`](https://github.com/dfinity/ic/commit/1e4faccbc) Execution: unify management canister doc comments for Rust types ([#7062](https://github.com/dfinity/ic/pull/7062))

### Not modifying GuestOS
Expand Down Expand Up @@ -299,6 +298,7 @@ def test_reconciler_publishes_tentative_changelog_when_changelog_not_yet_approve
* [`c027ae49c`](https://github.com/dfinity/ic/commit/c027ae49c) Node: duplicate kill_start_test into a long and short version ([#7060](https://github.com/dfinity/ic/pull/7060))

### The change is not owned by any replica or HostOS team
* [`a21d0e6a3`](https://github.com/dfinity/ic/commit/a21d0e6a3) Boundary Nodes: add aliases for request type variants for backwards compatibility ([#7032](https://github.com/dfinity/ic/pull/7032))
* [`fb4dff62d`](https://github.com/dfinity/ic/commit/fb4dff62d) Financial Integrations(icrc-ledger-types): Add try_from_subaccount_to_principal ([#6911](https://github.com/dfinity/ic/pull/6911))
""".rstrip()
expected_hostos_release_notes = """We're preparing [a new IC release](https://github.com/dfinity/ic/tree/release-2025-10-12_01-01-base).
Expand Down
4 changes: 2 additions & 2 deletions release-controller/tests/test_release_notes.py
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def test_guestos_release_notes(ic_repo: GitRepo) -> None:
* ~~author: dani | [`448c85ccc`](https://github.com/dfinity/ic/commit/448c85ccc) NNS: Added include_public_neurons_in_full_neurons to ListNeurons. ([#589](https://github.com/dfinity/ic/pull/589)) [AUTO-EXCLUDED:Changed files are excluded by file path filter]~~
* ~~author: jaso | [`2b109fb9b`](https://github.com/dfinity/ic/commit/2b109fb9b) NNS: Define update_canister_settings proposal type without execution ([#529](https://github.com/dfinity/ic/pull/529)) [AUTO-EXCLUDED:Changed files are excluded by file path filter]~~
## Bugfixes:
* ~~author: r-bi | [`d5a950484`](https://github.com/dfinity/ic/commit/d5a950484) Boundary Nodes(ic-boundary): switch logging setup from eager to lazy eval ([#658](https://github.com/dfinity/ic/pull/658)) [AUTO-EXCLUDED:Changed files are excluded by file path filter]~~
* ~~author: r-bi | [`d5a950484`](https://github.com/dfinity/ic/commit/d5a950484) Boundary Nodes(ic-boundary): switch logging setup from eager to lazy eval ([#658](https://github.com/dfinity/ic/pull/658)) [AUTO-EXCLUDED:The change is not owned by any replica or HostOS team]~~
* author: Adri Alic | [`2bdfdc54c`](https://github.com/dfinity/ic/commit/2bdfdc54c) Consensus: Use correct signer id in make_next_block_with_rank ([#644](https://github.com/dfinity/ic/pull/644))
* author: Dimi Sarl | [`9fc5fc83f`](https://github.com/dfinity/ic/commit/9fc5fc83f) Interface: Update computation of effective canister id for FetchCanisterLogs ([#540](https://github.com/dfinity/ic/pull/540))
* ~~author: Andr Popo | [`395c0e49a`](https://github.com/dfinity/ic/commit/395c0e49a) NNS(sns): Enforce a minimum on the maximum number of permissioned principals an SNS neuron is allowed to have ([#649](https://github.com/dfinity/ic/pull/649)) [AUTO-EXCLUDED:Changed files are excluded by file path filter]~~
Expand Down Expand Up @@ -351,7 +351,7 @@ def test_hostos_release_notes(ic_repo: GitRepo) -> None:
* ~~author: Math Björ | [`5599a9860`](https://github.com/dfinity/ic/commit/5599a9860) Financial Integrations(ICRC_Ledger): Recompute ICRC ledger certified data in post upgrade ([#4796](https://github.com/dfinity/ic/pull/4796)) [AUTO-EXCLUDED:The change is not owned by any replica or HostOS team]~~
* author: Shuo Wang | [`79f0a7d1f`](https://github.com/dfinity/ic/commit/79f0a7d1f) Message Routing: switch to checkpoint for wasm binaries in canister snapshots ([#4777](https://github.com/dfinity/ic/pull/4777))
* author: Bas van | [`c9210f4d2`](https://github.com/dfinity/ic/commit/c9210f4d2) Node: revert "chore: unifying downloading logic ([#4805](https://github.com/dfinity/ic/pull/4805))" ([#4836](https://github.com/dfinity/ic/pull/4836))
* ~~author: Igor Novg | [`e564b0380`](https://github.com/dfinity/ic/commit/e564b0380) Node: api bn: update `ic-gateway`, increase h2 streams, lower shedding threshold ([#4818](https://github.com/dfinity/ic/pull/4818)) [AUTO-EXCLUDED:Changed files are excluded by file path filter]~~
* author: Igor Novg | [`e564b0380`](https://github.com/dfinity/ic/commit/e564b0380) Node: api bn: update `ic-gateway`, increase h2 streams, lower shedding threshold ([#4818](https://github.com/dfinity/ic/pull/4818))
## Chores:
* author: Andr Batt | [`b60e4861d`](https://github.com/dfinity/ic/commit/b60e4861d) Consensus(node): Improve orchestrator node_operator_private_key.pem logging ([#4753](https://github.com/dfinity/ic/pull/4753))
* author: kpop | [`6876dcac8`](https://github.com/dfinity/ic/commit/6876dcac8) Consensus(ic-replay): add more logs to `ic-replay` ([#4685](https://github.com/dfinity/ic/pull/4685))
Expand Down
Loading