Fixes for Mii struct and FRD_GetFriendKeyList#578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduced a regression which caused users to see invalid data when accessing the
FriendMiistruct. This was caused by the presence of extra fields at the beginning of the struct that are not actually part of the data returned by the friends sysmodule.The changes made here:
CFLStoreDatafromact.htomii.has it turns out this struct is shared across many titles and sysmodules;FriendMiiasCFLStoreDataso that commands taking inFriendMiior returning structs that contain Mii data can be accessed properly.In addition, through my own testing I have discovered that
FRD_GetFriendKeyListwas passing invalid static buffer descriptors, causing a crash whenever this command was used, so I have corrected this as well.