feat - new search react component#2261
Merged
Merged
Conversation
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
skeptrunedev
requested changes
Aug 29, 2024
Contributor
skeptrunedev
left a comment
skeptrunedev
left a comment
There was a problem hiding this comment.
Major nit I have is that it should show the title then, subsequently, the highlights below it. If the title is in the chunk_html then it should be removed as well. I would look for children matching the title text and remove those then mark the title as highlighted. But also maybe don't remove? I'm not sure, should study how Mintlify does it.
Contributor
|
I think we should highly prioritize setting up chat for this as well |
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
Author
|
The highlights should be much better now and will work on chat tomorrow |
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
SaraVieira
temporarily deployed
to
github-pages
GitHub Actions
Inactive
skeptrunedev
force-pushed
the
feat/react-search-component
branch
from
3364057 to
d07ad8a
Compare
skeptrunedev
force-pushed
the
feat/react-search-component
branch
from
d07ad8a to
d732771
Compare
skeptrunedev
force-pushed
the
feat/react-search-component
branch
from
d732771 to
32535fd
Compare
skeptrunedev
approved these changes
Aug 31, 2024
Contributor
skeptrunedev
left a comment
skeptrunedev
left a comment
There was a problem hiding this comment.
This is awesome. Definitely a fully functional component for search and I'm hype about it. Arrows and everything work and the display looks great.
Sorry for being pedantic with the commit history, but I'm nervous our total commit count is getting too large and makes us seem sus lol. Hype about this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example: https://trieve-react-search.surge.sh/