Skip to content

chore(testing): update snapshot testing expectations - #4416

Merged
kt3k merged 1 commit into
denoland:mainfrom
kt3k:chore-update-snapshot-test-expectations
Feb 29, 2024
Merged

chore(testing): update snapshot testing expectations#4416
kt3k merged 1 commit into
denoland:mainfrom
kt3k:chore-update-snapshot-test-expectations

Conversation

@kt3k

@kt3k kt3k commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

The string patterns for indicating output during test executions have been changed in denoland/deno#22611, and snapshot test cases are affected by that change. This PR updates the expectations of these test cases to pass CI with Deno canary.

This PR also disables CI for v1.x because it can't pass with those versions.

@kt3k kt3k changed the title chore(test): update snapshot testing expectations chore(testing): update snapshot testing expectations Feb 29, 2024

@iuioiua iuioiua left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@kt3k
kt3k merged commit 45f7a6b into denoland:main Feb 29, 2024
@kt3k
kt3k deleted the chore-update-snapshot-test-expectations branch February 29, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants