Skip to content

BREAKING(collections): remove groupBy() - #3923

Merged
iuioiua merged 2 commits into
mainfrom
remove-collections-groupby
Dec 22, 2023
Merged

BREAKING(collections): remove groupBy()#3923
iuioiua merged 2 commits into
mainfrom
remove-collections-groupby

Conversation

@iuioiua

@iuioiua iuioiua commented Dec 11, 2023

Copy link
Copy Markdown
Contributor

To be merged for v0.211.0.

See also #3663

@iuioiua
iuioiua marked this pull request as ready for review December 21, 2023 20:17
@iuioiua
iuioiua requested a review from kt3k as a code owner December 21, 2023 20:17
@iuioiua
iuioiua enabled auto-merge (squash) December 22, 2023 10:32

@kt3k kt3k left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua
iuioiua merged commit 59229e0 into main Dec 22, 2023
@iuioiua
iuioiua deleted the remove-collections-groupby branch December 22, 2023 10:33
@av

av commented Oct 22, 2024

Copy link
Copy Markdown

This change made me greatly confused while exploring @std/collections.

groupBy is the main reason why I'm reaching out to lodash-like libraries, so not being able to find it at first, and then having to discover it was removed (without a trace of explanation) was a bit frustrating.

@iuioiua

iuioiua commented Oct 22, 2024

Copy link
Copy Markdown
Contributor Author

Apologies, @av. Yes, we should've included relevant info. groupBy() was replaced by the JS-native Object.groupBy().

@av

av commented Oct 22, 2024

Copy link
Copy Markdown

Thanks for getting back to me. I figured it out, just wanted to leave some feedback for the team. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants