fix(archive/untar.ts): Cannot access symlinks in archives - #3686
Merged
Conversation
Added a `linkName` optional property to class `TarEntry` so that the destination of symbolic link entries can be read.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3232
Added a
linkNameoptional property to classTarEntryso that the destination of symbolic link entries can be read. The entry is optional so that existing code that processes files, directories, etc. don't see an unexpected new property, but the property is set for entries of type "symlink".The change is minimal so that existing tests are unchanged but a new test that extracts an archive containing a file and a symbolic link to this file demonstrates the new behavior.
A couple of existing lines were reformatted by
deno fmt, but I assume that we want all files formatted...