Skip to content

feat: web streams based archive/tar - #1985

Closed
crowlKats wants to merge 43 commits into
denoland:mainfrom
crowlKats:tar_stream
Closed

feat: web streams based archive/tar#1985
crowlKats wants to merge 43 commits into
denoland:mainfrom
crowlKats:tar_stream

Conversation

@crowlKats

@crowlKats crowlKats commented Mar 3, 2022

Copy link
Copy Markdown
Member

still WIP

closes #1658

Comment thread archive/tar_stream_test.ts Outdated
Comment thread archive/tar_stream.ts Outdated
@bartlomieju

Copy link
Copy Markdown
Member

@crowlKats there's already #1855. Should one of the PRs be closed?

@crowlKats

Copy link
Copy Markdown
Member Author

@bartlomieju well, the approach of the other PR wont work, and this PR right now is stuck due to upstream spec change needed

crowlKats and others added 2 commits March 8, 2022 02:43
Co-authored-by: Jesse Jackson <jsejcksn@users.noreply.github.com>
Co-authored-by: Jesse Jackson <jsejcksn@users.noreply.github.com>
@danopia

danopia commented Mar 23, 2022

Copy link
Copy Markdown

due to upstream spec change needed

I'm curious if there is a reference on what is needed / where the conversation is?

Also as an outsider it seems that the filePath shorthand parameter will not be available in the new API to allow removing all Deno.* dependencies, is that right?

Cross link:

@crowlKats

Copy link
Copy Markdown
Member Author

@danopia whatwg/streams#1145, and yes, filePath wont be available

@bartlomieju

Copy link
Copy Markdown
Member

Still blocked by spec update

@iuioiua

iuioiua commented Dec 21, 2022

Copy link
Copy Markdown
Contributor

@crowlKats, are there any possible workarounds for this PR? Perhaps, some alternative API that's come up since the last update or a WASM alternative? Disclaimer: I'm unfamiliar with this implementation.

@crowlKats

Copy link
Copy Markdown
Member Author

@iuioiua I sadly believe no

@csvn

csvn commented Nov 15, 2023

Copy link
Copy Markdown

The whatwg/streams#1145 PR has now been merged. Is this PR now unblocked, or does this require V8/Deno updates before STD can be updated?

@csvn

csvn commented Nov 15, 2023

Copy link
Copy Markdown

Nevermind, sorry. Saw there is work on this in denoland/deno#20849.

@crowlKats

Copy link
Copy Markdown
Member Author

yep, once that PR lands in Deno, I'll work on this PR again

@iuioiua iuioiua mentioned this pull request Dec 2, 2023
38 tasks
@crowlKats
crowlKats requested a review from kt3k as a code owner December 18, 2023 10:37
@crowlKats

Copy link
Copy Markdown
Member Author

Blocked on #3982

@iuioiua

iuioiua commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

@crowlKats, are you able to complete documentation so deno doc --lint archive/tar_stream.ts and deno doc --lint archive/untar_stream.ts pass?

@iuioiua
iuioiua marked this pull request as draft December 21, 2023 02:10
@iuioiua

iuioiua commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

Closing in favor of #4548.

@iuioiua iuioiua closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modernize std/archive/tar

6 participants