Skip to content

feat: streams based Buffer - #1970

Merged
crowlKats merged 2 commits into
denoland:mainfrom
crowlKats:streams_buffer
Mar 5, 2022
Merged

feat: streams based Buffer#1970
crowlKats merged 2 commits into
denoland:mainfrom
crowlKats:streams_buffer

Conversation

@crowlKats

@crowlKats crowlKats commented Feb 28, 2022

Copy link
Copy Markdown
Member

Equivalent of std/io/buffer.ts's Buffer but with streams

Comment thread streams/buffer.ts
@bartlomieju

Copy link
Copy Markdown
Member

What's the use case for this? Why create a new class with the same name instead of adding this functionality to existing Buffer?

@crowlKats

Copy link
Copy Markdown
Member Author

@bartlomieju well, we want various Deno.Reader/Writer based APIs to be written/ported to streams. These should be in their own file so there in no dependency on the aforementioned APIs

@bartlomieju bartlomieju left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsejcksn

jsejcksn commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

What's the use case for this? Why create a new class with the same name instead of adding this functionality to existing Buffer?

@crowlKats Does this also allow for browser compatibility? If so, please mark it as such.

@crowlKats

Copy link
Copy Markdown
Member Author

@jsejcksn nope, once again, typescript is behind the times with outdated typings

@jsejcksn

jsejcksn commented Mar 5, 2022

Copy link
Copy Markdown
Contributor

@jsejcksn nope, once again, typescript is behind the times with outdated typings

@crowlKats There's a tracking issue for compat issues caused by outdated native TS types here. Will you add any candidate modules there?

@crowlKats

Copy link
Copy Markdown
Member Author

@jsejcksn done

@crowlKats
crowlKats merged commit 5502575 into denoland:main Mar 5, 2022
@crowlKats
crowlKats deleted the streams_buffer branch March 5, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants