Skip to content

Fix/xsup 76577/rasterize extract lightweight freeze - #45947

Open
MosheEichler wants to merge 4 commits into
masterfrom
fix/XSUP-76577/rasterize-extract-lightweight-freeze
Open

MosheEichler wants to merge 4 commits into
masterfrom
fix/XSUP-76577/rasterize-extract-lightweight-freeze

Conversation

@MosheEichler

@MosheEichler MosheEichler commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Description

In lightweight mode the memory guard froze the tab after every page load, which disables JavaScript execution and purges the V8 heap. rasterize-extract is the only rasterize type that runs JS in the page (Runtime.evaluate), so the freeze destroyed the execution context it was about to use — the command failed with Cannot find default execution context and returned no content.

Change: added a freeze_on_load flag (default True) to wait_for_page_load_with_memory_guard and navigate_to_path, and pass False from extract_text_content.

  • Screenshot/PDF captures are unchanged — they only need the last painted frame, which survives the freeze.
  • The memory-pressure freeze is unaffected: under real pressure the tab is still frozen, since avoiding the OOM takes precedence.
  • Non-lightweight tenants are unaffected (that path never freezes).

Must have

  • Tests
  • Documentation

@MosheEichler MosheEichler self-assigned this Sep 17, 2026
@MosheEichler MosheEichler added release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Sep 17, 2026
@content-bot

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Sep 17, 2026
@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor
🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thanks for your contribution to the rasterize pack. The changes look great, but there is just a minor formatting tweak needed in the release notes to align with our entity styling guidelines. Great work on fixing the content extraction issue!

@MosheEichler please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/rasterize/ReleaseNotes/2_1_46.md Outdated
Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com>
@MosheEichler
MosheEichler marked this pull request as ready for review September 17, 2026 14:01
@MosheEichler MosheEichler added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Sep 17, 2026
@MosheEichler
MosheEichler enabled auto-merge (squash) September 17, 2026 14:01
@content-bot

Copy link
Copy Markdown
Contributor

Validate summary
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot

Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: 7d5de5da537f7929

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants