Skip to content

IBM Secrets Manager: add event collector (CIAC-17197) - #45935

Open
RosenbergYehuda wants to merge 3 commits into
masterfrom
CIAC-17197-ibm-secrets-manager-event-collector
Open

IBM Secrets Manager: add event collector (CIAC-17197)#45935
RosenbergYehuda wants to merge 3 commits into
masterfrom
CIAC-17197-ibm-secrets-manager-event-collector

Conversation

@RosenbergYehuda

@RosenbergYehuda RosenbergYehuda commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Description

Must have

  • Tests
  • Documentation

@RosenbergYehuda
IBM Secrets Manager: add event collector (CIAC-17197)
4cfc86d 
Add a new IBM Secrets Manager pack with an XSIAM event collector that
collects Secrets Manager audit / Activity Tracker events via the IBM
Cloud Logs query API (POST /v1/query, SSE), authenticating with IBM
Cloud IAM (API key -> short-lived Bearer). Includes test-module,
ibm-secrets-manager-get-events, fetch-events with half-open window
de-dup, and unit tests.
@RosenbergYehuda RosenbergYehuda self-assigned this Sep 16, 2026
@content-bot

content-bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions

github-actions Bot commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/IBMSecretsManager/Integrations/IBMSecretsManager
   IBMSecretsManager.py1111090%227–231, 284–285, 287, 299–300
TOTAL1111090% 

Tests Skipped Failures Errors Time
12 0 💤 0 ❌ 0 🔥 2.789s ⏱️

github-code-quality[bot]
github-code-quality Bot found potential problems Sep 16, 2026
View reviewed changes
Comment thread Packs/IBMSecretsManager/Integrations/IBMSecretsManager/IBMSecretsManager.py Fixed
@content-bot

This comment has been minimized.

Sign in to view
@RosenbergYehuda
rename
a0b892d
@RosenbergYehuda
IBM Secrets Manager: align naming to design and wording to Cortex
e73e65a 
- Rename integration id/name/display and folder/files from
  IBMSecretsManagerEventCollector to IBMSecretsManager to match the
  design (display name 'IBM Secrets Manager'); update defaultDataSource,
  test imports, and docs.
- Replace 'Cortex XSIAM' with 'Cortex' in all user-facing text since the
  collected events serve multiple Cortex products.
@content-bot

content-bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

⚠️ The PR is missing the ready-for-pipeline-running label. Please add the label when the PR is ready in order to proceed.

github-code-quality[bot]
github-code-quality Bot found potential problems Sep 17, 2026
View reviewed changes
Comment thread Packs/IBMSecretsManager/Integrations/IBMSecretsManager/IBMSecretsManager.py
import json

import demistomock as demisto # noqa: F401
from CommonServerPython import * # noqa: F401
@content-bot

content-bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Validate summary
The following errors were reported as warnings: BC117.
BC117 validation requires PM review due to changes to supportedModules.
The following errors were thrown as a part of this pr: PA132, IN161, IN169, BA133, DO106.
The following errors can be ignored: IN161.
The following errors cannot be ignored: PA132, IN169, BA133, DO106.
The following errors don't run as part of the nightly flow and therefore can be force merged: BA133, DO106.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ❌

@content-bot

content-bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: 89112e3dd614bbee

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@RosenbergYehuda RosenbergYehuda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RosenbergYehuda @content-bot